ci(jenkins): don't run TAV tests for Node.js core modules

[watson]

Previously if there was a change to any of our patches for a Node.js core modules (e.g. http), Jenkins would try to run TAV tests for the http module. This is just a waste of resources as there are no TAV tests for core modules.

This commit will filter out any core module from the list of modules being considered for TAV tests.

[watson]

@v1v Does this somehow conflict with the change in #1351 because I'm also adding quotes here?

[v1v]

They are independent:

• ci(jenkins): tav with different formats #1351 refers only when there is a GitHub comment and matches with the TAV comment format.

  apm-agent-nodejs/Jenkinsfile

  Line 383 in 14abfe7

  if (env.GITHUB_COMMENT) {

• While this PR is regarding what source code changes have been pushed onto the PR.

  apm-agent-nodejs/Jenkinsfile

  Line 401 in 14abfe7

  } else if (env.CHANGE_ID && env.TAV_UPDATED != "false") {

[v1v]

So if someone might change https://github.com/elastic/apm-agent-nodejs/blob/master/lib/instrumentation/modules/http.js then this particular script should skip running the TAV for the module http, right?

[watson]

@v1v Correct. I discovered this in #1340 where it tried to run the http2 TAV tests: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/PR-1340/12/pipeline

[Qard]

I think this PR may have missed dealing with the TAV_UPDATED flag in the Jenkinsfile. It's resulting in failed attempts to load a .ci/.jenkins_generated_tav.yml file.

[watson]

@Qard fixed in #1363