Fix tests with python 3.13 #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same thing fix plz |
|
same problem 😊 |
lsaint
approved these changes
Mar 11, 2025
xrmx
force-pushed
the
python3.13-support
branch
2 times, most recently
from
bbfd0b7 to
a69375f
Compare
With Python 3.13 our pattern of buffering revealed some issues because
the underlying BytesIO fileobj may get released before gzip.GzipFile.
This requires a fix in CPython but also some improvements on our side by
properly closing the GzipFile in case of error and also releasing the
memoryview we can from the BytesIO buffer.
These problems manifests as following warnings from unraisable exceptions
running tests:
The closing of the gzip buffer helps with:
Traceback (most recent call last):
File "/usr/lib/python3.13/gzip.py", line 362, in close
fileobj.write(self.compress.flush())
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed file.
Exception ignored in: <_io.BytesIO object at 0x7fbc4335fbf0>
Traceback (most recent call last):
File "/venv313/lib/python3.13/site-packages/ecs_logging/_stdlib.py", line 272, in _record_attribute
def _record_attribute(
BufferError: Existing exports of data: object cannot be re-sized
Python 3.12 shows the same warnings with the `-X dev` flag.
Handle _partialmethod moving to __partialmethod__ in Python 3.13
basepi
approved these changes
Apr 7, 2025
|
@xrmx Is it fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This fixes a couple of issues regarding our send buffer handling and updates some code in order to run tests with python 3.13.
Related issues
Refs #2213