chore: add provenance and trusted publishers in release workflow #1651
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
v1v
reviewed
Oct 29, 2025
Member
v1v
left a comment
v1v
left a comment
There was a problem hiding this comment.
LGTM, just a couple of changes:
- to keep the least-permissive token access at the job level
- to remove the NPM_TOKEN usage, trusted publishers won't use it
Comment on lines
-25
to
-27
| permissions: | ||
| contents: read | ||
| id-token: write |
Member
There was a problem hiding this comment.
Let's keep this as is, we normally follow this pattern:
- default top-level permissions as is
- job permissions with finer-granularity
| DRY_RUN: "${{ inputs.dry-run }}" | ||
| GITHUB_TOKEN: ${{ steps.get_token.outputs.token }} | ||
| run: | | ||
| echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc |
Member
There was a problem hiding this comment.
This should be removed too if we use the trusted publishers
Suggested change
Member
|
@david-luna , If you need help with testing this PR, let me know, I recall I had some test packages to run on my forked repository: so we could try it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add provenance and trusted publishers to Elastic APM RUM packages. It also adds
--ignore-scriptsnpm CLI option wherever possible.Closes: #1644
Supersedes: #1489