Skip to content

[Bug] Makefile test-remote-cli Defined Twice #4751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eric-forte-elastic
Copy link
Contributor

Pull Request

Issue link(s): #4750

Summary - What I changed

Updated the Makefile to fix the duplicate entry, and fixed a minor bug in the test script which had hard coded paths and updated the comparison logic to support relative paths, as required to remove the hard coded paths.

How To Test

Run make test-hunting-cli with an appropriately configured/defined .detection-rules-cfg.json. If you are using a remote stack in this configuration, this command should produce no warnings or errors.

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@eric-forte-elastic eric-forte-elastic requested a review from traut May 28, 2025 18:55
@eric-forte-elastic eric-forte-elastic self-assigned this May 28, 2025
@eric-forte-elastic eric-forte-elastic added bug Something isn't working cli command line tooling labels May 28, 2025
@eric-forte-elastic eric-forte-elastic linked an issue May 28, 2025 that may be closed by this pull request
@eric-forte-elastic eric-forte-elastic added the python Internal python for the repository label May 28, 2025
@botelastic botelastic bot added the Hunting label May 28, 2025
Copy link
Contributor

Bug - Guidelines

These guidelines serve as a reminder set of considerations when addressing a bug in the code.

Documentation and Context

  • Provide detailed documentation (description, screenshots, reproducing the bug, etc.) of the bug if not already documented in an issue.
  • Include additional context or details about the problem.
  • Ensure the fix includes necessary updates to the release documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Code changes do not introduce new warnings or errors.
  • Variables and functions are well-named and descriptive.
  • Any unnecessary / commented-out code is removed.
  • Ensure that the code is modular and reusable where applicable.
  • Check for proper exception handling and messaging.

Testing

  • New unit tests have been added to cover the bug fix or edge cases.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and detecting the bug fix (e.g., test logs, screenshots).
  • Validate that any rules affected by the bug are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.

Additional Checks

  • Ensure that the bug fix does not break existing functionality.
  • Review the bug fix with a peer or team member for additional insights.
  • Verify that the bug fix works across all relevant environments (e.g., different OS versions).
  • Confirm that all dependencies are up-to-date and compatible with the changes.
  • Confirm that the proper version label is applied to the PR patch, minor, major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto bug Something isn't working cli command line tooling Hunting patch python Internal python for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Makefile Test Remote CLI defined Twice
1 participant