Move CI lint job to the curb GitHub Action - #3953
Merged
Merged
Conversation
Replaces the dotnet-bootstrap-and-run-build-script lint step with nullean/curb's pre-built container action, so the job no longer needs the .NET SDK, tool restore, or Node setup just to check formatting. Also updates CONTRIBUTING.md's Husky.Net docs, which still described dotnet-lint as a pre-push dotnet-format hook after #3904 moved it to a pre-commit curb hook. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@reakaleek @theletterf getting this one in as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Now that #3904 migrated the formatting toolchain from
dotnet formatto curb, thelintCI job no longer needs a full .NET SDK bootstrap (tool restore, Node setup, etc.) just to run a formatting check — curb ships as a pre-built container image via its own GitHub Action.What
lintjob in.github/workflows/ci.ymlnow usesnullean/curb(pinned to the0.7.1commit SHA, per this repo's zizmor policy for non-actions/*/elastic/*actions) instead of checking out the repo, bootstrapping .NET/Node, and running./build.sh lint.CONTRIBUTING.md's Husky.Net section, which still describeddotnet-lintas a pre-push hook runningdotnet format --verify-no-changes— Migrate formatting toolchain from dotnet format to curb #3904 had already moved it to a pre-commit hook runningdotnet curb check, but the docs weren't updated to match.Made with Cursor