-
Notifications
You must be signed in to change notification settings - Fork 68
Add ECS conversion tables #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECS conversion tables #1186
Conversation
…//github.com/elastic/docs-content into theletterf-describe-ecs-attribute-conversion
…//github.com/elastic/docs-content into theletterf-describe-ecs-attribute-conversion
@carsonip Split the docs:
Copilot helped me create a table of conditionally created fields/labels here: https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1186/solutions/observability/apm/resource-attributes#conditionally-c[…]es-in-traces.go |
Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR but I'm afraid copilot isn't doing a great job here. If we're going down the path of exhaustively documenting every translation, we'll need to ensure they are complete and correct. The current state of this PR is quite far from that.
As the docs owner, would you like to revisit the strategy of documenting these translations?
…//github.com/elastic/docs-content into theletterf-describe-ecs-attribute-conversion
I've now reduced to the PR to the facts we can surely defend. Whether customers will ask for detailed conversion could be addressed in a following issue. |
Docs is now generically called "Attributes" and establishes a link to APM Server's labels in the intro. Redirects have been put in place to avoid broken links. |
Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
…//github.com/elastic/docs-content into theletterf-describe-ecs-attribute-conversion
@carsonip Ready for a final look, I'd say. |
Fixes elastic/apm-server#15509
Take the content in elastic/observability-docs#4843, converts it to Markdown and apply edits for style and structure.
+CC @harshithsaiv