Skip to content

Add ECS conversion tables #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 24, 2025
Merged

Conversation

theletterf
Copy link
Contributor

@theletterf theletterf commented Apr 17, 2025

Fixes elastic/apm-server#15509

Take the content in elastic/observability-docs#4843, converts it to Markdown and apply edits for style and structure.

+CC @harshithsaiv

@theletterf theletterf requested a review from carsonip April 22, 2025 14:37
@theletterf theletterf requested a review from carsonip April 22, 2025 16:53
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR but I'm afraid copilot isn't doing a great job here. If we're going down the path of exhaustively documenting every translation, we'll need to ensure they are complete and correct. The current state of this PR is quite far from that.

As the docs owner, would you like to revisit the strategy of documenting these translations?

@theletterf
Copy link
Contributor Author

I've now reduced to the PR to the facts we can surely defend. Whether customers will ask for detailed conversion could be addressed in a following issue.

@theletterf theletterf requested a review from carsonip April 23, 2025 07:22
@theletterf
Copy link
Contributor Author

Docs is now generically called "Attributes" and establishes a link to APM Server's labels in the intro. Redirects have been put in place to avoid broken links.

@theletterf theletterf requested a review from carsonip April 23, 2025 14:02
@theletterf theletterf self-assigned this Apr 23, 2025
@theletterf theletterf requested a review from carsonip April 24, 2025 12:05
@theletterf theletterf requested a review from carsonip April 24, 2025 12:42
@theletterf
Copy link
Contributor Author

@carsonip Ready for a final look, I'd say.

@theletterf theletterf merged commit b3223b8 into main Apr 24, 2025
4 checks passed
@theletterf theletterf deleted the theletterf-describe-ecs-attribute-conversion branch April 24, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: describe how OTel resource attributes are translated and stored in labels
2 participants