Skip to content

Add ESQL result type definitions #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Add ESQL result type definitions #4189

merged 3 commits into from
Apr 9, 2025

Conversation

swallez
Copy link
Member

@swallez swallez commented Apr 2, 2025

Adds the API spec for the JSON output of ES|QL query (other formats cannot be represented here).

Copy link
Contributor

github-actions bot commented Apr 2, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query_delete Missing test Missing test
esql.async_query_get Missing test Missing test
esql.async_query_stop Missing test Missing test
esql.async_query Missing test Missing test
esql.query 293/293 Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query_delete Missing test Missing test
esql.async_query_get Missing test Missing test
esql.async_query_stop Missing test Missing test
esql.async_query Missing test Missing test
esql.query 293/293 Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query_delete Missing test Missing test
esql.async_query_get Missing test Missing test
esql.async_query_stop Missing test Missing test
esql.async_query Missing test Missing test
esql.query 293/293 Missing test

You can validate these APIs yourself by using the make validate target.

@swallez swallez merged commit e9322d6 into main Apr 9, 2025
8 checks passed
@swallez swallez deleted the esql-result branch April 9, 2025 11:52
github-actions bot pushed a commit that referenced this pull request Apr 9, 2025
Anaethelion pushed a commit that referenced this pull request Apr 9, 2025
swallez added a commit that referenced this pull request Apr 9, 2025
(cherry picked from commit e9322d6)

Co-authored-by: Sylvain Wallez <[email protected]>
JoshMock added a commit to elastic/elasticsearch-js that referenced this pull request Apr 14, 2025
The ESQL helper needs to reflect the types added to the spec in
elastic/elasticsearch-specification#4189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants