-
Notifications
You must be signed in to change notification settings - Fork 99
Adds new embedding_type
values to PUT Cohere inference endpoint
#4403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
embedding_type
values to PUT Cohere inference endpoint
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@@ -585,6 +585,8 @@ export class CohereServiceSettings { | |||
api_key: string | |||
/** | |||
* For a `text_embedding` task, the types of embeddings you want to get back. | |||
* Use `binary` for binary embeddings, which are encoded as bytes with signed int8 precision. | |||
* Use `bit` for binary embeddings, which are encoded as bytes with signed int8 precision (this is a synonym of `binary`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also want to add these two new values to the enum CohereEmbeddingType
list a bit further down in the file so that they are treated as valid options in code generated from the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JoshMock, I picked this up since @szabosteve is out this week. I’ve updated the PR based on your suggestion - could you please take a look and approve it if everything looks good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding that.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- Co-authored-by: kosabogi <[email protected]> Co-authored-by: kosabogi <[email protected]> (cherry picked from commit dc80ba5)
@szabosteve is this also supposted to be backported to 9.0? |
) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- Co-authored-by: kosabogi <[email protected]> Co-authored-by: kosabogi <[email protected]> (cherry picked from commit dc80ba5)
) (#4432) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- (cherry picked from commit dc80ba5) Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: kosabogi <[email protected]> Co-authored-by: kosabogi <[email protected]> Co-authored-by: Laura Trotta <[email protected]>
) (#4419) * Adds new embedding_type values to PUT Cohere inference endpoint. * Adds values to the CohereEmbeddingType enum --------- (cherry picked from commit dc80ba5) Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: kosabogi <[email protected]> Co-authored-by: kosabogi <[email protected]> Co-authored-by: Laura Trotta <[email protected]>
Overview
Related to elastic/docs-content#310
Two new embedding types are supported via elastic/elasticsearch#120751. This PR expands the
embedding_type
value description of the PUT Cohere inference endpoint to reflect the changes.