Skip to content

Search endpoint fixes #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Search endpoint fixes #4420

wants to merge 1 commit into from

Conversation

l-trotta
Copy link
Contributor

Slowly increasing validation score for search.

The last 2 are breaking changes for static clients so I'm wondering if we should even introduce them just for the sake of validation, since it's not really broken, but it currently does not comply 100% with what the server can accept.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2349/2401 2385/2385

You can validate this API yourself by using the make validate target.

@l-trotta
Copy link
Contributor Author

2349/2401 2385/2385

before it was 2316/2401 2384/2385

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side.

I would as well be fine with the breaking changes.

Btw: I think there is another retriever missing (the LinearRetriever).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants