Slack merge throttling params for fewer merge tasks #126016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
| @@ -87,8 +87,8 @@ public class ThreadPoolMergeExecutorService { | |||
| private ThreadPoolMergeExecutorService(ThreadPool threadPool) { | |||
| this.executorService = threadPool.executor(ThreadPool.Names.MERGE); | |||
| this.maxConcurrentMerges = threadPool.info(ThreadPool.Names.MERGE).getMax(); | |||
| this.concurrentMergesFloorLimitForThrottling = maxConcurrentMerges * 2; | |||
| this.concurrentMergesCeilLimitForThrottling = maxConcurrentMerges * 4; | |||
| this.concurrentMergesFloorLimitForThrottling = 2; | |||
There was a problem hiding this comment.
Can we put a comment here that this means to only decrease throttle rate when we submit a task and no other tasks are running?
| this.concurrentMergesFloorLimitForThrottling = maxConcurrentMerges * 2; | ||
| this.concurrentMergesCeilLimitForThrottling = maxConcurrentMerges * 4; | ||
| this.concurrentMergesFloorLimitForThrottling = 2; | ||
| this.concurrentMergesCeilLimitForThrottling = maxConcurrentMerges * 2; | ||
| } |
There was a problem hiding this comment.
Perhaps assert that concurrentMergesCeilLimitForThrottling >= concurrentMergesFloorLimitForThrottling - I feel like it adds readabililty.
| newTargetIORateBytesPerSec = Math.min( | ||
| MAX_IO_RATE.getBytes(), | ||
| currentTargetIORateBytesPerSec + currentTargetIORateBytesPerSec / 10L | ||
| currentTargetIORateBytesPerSec + currentTargetIORateBytesPerSec / 20L |
There was a problem hiding this comment.
I think what you did only adds 5%, it should be:
Suggested change
| currentTargetIORateBytesPerSec + currentTargetIORateBytesPerSec / 20L | |
| currentTargetIORateBytesPerSec + currentTargetIORateBytesPerSec / 5L |
?
There was a problem hiding this comment.
Thanks for catching this!
|
Thanks for the review, @henningandersen , I've addressed it all, please take another look. |
henningandersen
approved these changes
Apr 2, 2025
server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceTests.java
Outdated
Show resolved
Hide resolved
…MergeExecutorServiceTests.java Co-authored-by: Henning Andersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent here is to aim for fewer to-do merges enqueued for execution,
and to unthrottle disk IO at a faster rate when the queue grows longer.
Overall this results in less merge disk throttling.
Relates https://github.com/elastic/elasticsearch-benchmarks/issues/2437 #120869