Fixing test failure #127657 #127659
Merged
Fixing test failure #127657 #127659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
| @@ -904,14 +904,17 @@ public void testRescoreVectorForNonQuantized() { | |||
| } | |||
|
|
|||
| public void testRescoreVectorOldIndexVersion() { | |||
| IndexVersion incompatibleVersion = IndexVersionUtils.randomVersionBetween( | |||
| random(), | |||
| IndexVersion incompatibleVersion = randomFrom( | |||
There was a problem hiding this comment.
I understand what this is trying to do but it looks a bit confusing to me. Why not the below:
IndexVersionUtils.randomVersionBetween(
random(),
Version::min(IndexVersionUtils.getLowestReadCompatibleVersion(), IndexVersions.UPGRADE_TO_LUCENE_10_0_0)
Version::max(IndexVersionUtils.getPreviousVersion(IndexVersions.ADD_RESCORE_PARAMS_TO_QUANTIZED_VECTORS_BACKPORT_8_X), IndexVersionUtils.getPreviousVersion(IndexVersions.ADD_RESCORE_PARAMS_TO_QUANTIZED_VECTORS))
)
There was a problem hiding this comment.
The problem with this is that if somebody adds a new index version for 8.x that is after ADD_RESCORE_PARAMS_TO_QUANTIZED_VECTORS_BACKPORT_8_X, it will have the version capability, but will be a version smaller than ADD_RESCORE_PARAMS_TO_QUANTIZED_VECTORS.
This is why its a disjoint version set.
svilen-mihaylov-elastic
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the old index pattern request poorly.
closes: #127657