Skip to content

Fix ShardBulkInferenceActionFilterIT#testRestart #127671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented May 3, 2025

Simplify and fix the wrong assumptions in this test.

Closes #127592
Closes #127593
Closes #127594

Simplify and fix the wrong assumptions in these tests.

Closes elastic#127536
Closes elastic#127592
Closes elastic#127593
Closes elastic#127594
@jimczi jimczi added >test Issues or PRs that are addressing/adding tests :Search Relevance/Search Catch all for Search Relevance v8.19.0 v9.1.0 labels May 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label May 3, 2025
@jimczi jimczi requested a review from Mikep86 May 5, 2025 10:20
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only thing blocking a 👍 is an update to muted-tests.yml

Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we make sure to update the PR description as well to exclude #127536?

@jimczi jimczi merged commit 798c105 into elastic:main May 6, 2025
17 checks passed
@jimczi jimczi deleted the fix_test_restart branch May 6, 2025 07:02
jimczi added a commit to jimczi/elasticsearch that referenced this pull request May 6, 2025
Simplify and fix the wrong assumptions in these tests.

Closes elastic#127592
Closes elastic#127593
Closes elastic#127594
elasticsearchmachine pushed a commit that referenced this pull request May 6, 2025
Simplify and fix the wrong assumptions in these tests.

Closes #127592
Closes #127593
Closes #127594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
3 participants