Skip to content

Fix IndexTemplateRegistryRolloverIT #127695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nielsbauman
Copy link
Contributor

My theory of why this test failed is that when we waited for the data stream to be marked for rollover, that condition was met on one of the nodes, causing us to index the documents to trigger the rollover, but the master node did not fully process the mark-for-rollover cluster state, resulting in the documents ending up in the first backing index.

Therefore, we use awaitClusterState to wait for the data stream to be marked for rollover, which waits on the master node by default.

Fixes #127692
Relates #122852

My theory of why this test failed is that when we waited for the data
stream to be marked for rollover, that condition was met on one of the
nodes, causing us to index the documents to trigger the rollover, but
the master node did not fully process the mark-for-rollover cluster
state, resulting in the documents ending up in the first backing index.

Therefore, we use `awaitClusterState` to wait for the data stream to be
marked for rollover, which waits on the master node by default.

Fixes elastic#127692
@nielsbauman nielsbauman added >test Issues or PRs that are addressing/adding tests :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v9.1.0 labels May 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a sensible theory and fix. LGTM 👍🏻

@nielsbauman nielsbauman enabled auto-merge (squash) May 6, 2025 11:16
@nielsbauman nielsbauman merged commit 1bfaec8 into elastic:main May 6, 2025
17 checks passed
@nielsbauman nielsbauman deleted the fix-index-template-registry-rollover-it branch May 6, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] IndexTemplateRegistryRolloverIT testRollover failing
3 participants