Skip to content

[Entitlements] Extract instrumentation initialization to a separate class #127702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

[Entitlements] Extract instrumentation initialization to a separate class #127702

merged 2 commits into from
May 5, 2025

Conversation

ldematte
Copy link
Contributor

@ldematte ldematte commented May 5, 2025

Move code specific to agent instrumentation initialization to a separate class

@ldematte ldematte added >refactoring auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure v8.18.2 v9.0.2 labels May 5, 2025
@ldematte ldematte requested a review from a team as a code owner May 5, 2025 08:32
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

prdoyle
prdoyle approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@prdoyle prdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is literally just moving some related methods out into their own class? Nothing controversial there.

@ldematte
Copy link
Contributor Author

ldematte commented May 5, 2025 •
edited
Loading

This is literally just moving some related methods out into their own class

Yes, very straightforward
Thanks!

@ldematte ldematte merged commit 23ab059 into elastic:main May 5, 2025
17 checks passed
@ldematte ldematte deleted the entitlements/extract-instrumentation-initialization branch May 5, 2025 14:08
@ldematte ldematte mentioned this pull request May 5, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts
❌ 8.18 Commit could not be cherrypicked due to conflicts
✅ 9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127702

ldematte added a commit to ldematte/elasticsearch that referenced this pull request May 5, 2025
@ldematte
[Entitlements] Extract instrumentation initialization to a separate c…
28f6d41 
…lass (elastic#127702)
elasticsearchmachine pushed a commit that referenced this pull request May 5, 2025
@ldematte
[Entitlements] Extract instrumentation initialization to a separate c…
9343efc 
…lass (#127702) (#127715)
ldematte added a commit to ldematte/elasticsearch that referenced this pull request May 6, 2025
@ldematte
[Entitlements] Extract instrumentation initialization to a separate c…
836bc89 
…lass (elastic#127702)
@ldematte ldematte mentioned this pull request May 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prdoyle prdoyle prdoyle approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >refactoring Team:Core/Infra Meta label for core/infra team v8.18.2 v8.19.0 v9.0.2 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldematte @elasticsearchmachine @prdoyle