Skip to content

Fix FileSettingsServiceIT race condition #128374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jfreden
Copy link
Contributor

@jfreden jfreden commented May 23, 2025

Same issue as https://github.com/elastic/elasticsearch-serverless/pull/3900

Instead of using handler keys as condition that reserved state has been updated, use the version.

Resolves: #128369

@jfreden jfreden requested a review from alexey-ivanov-es May 23, 2025 13:39
@jfreden jfreden added >test Issues or PRs that are addressing/adding tests :Core/Infra/Settings Settings infrastructure and APIs labels May 23, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 Team:Core/Infra Meta label for core/infra team labels May 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfreden jfreden added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 26, 2025
@elasticsearchmachine elasticsearchmachine merged commit 74d025e into elastic:main May 26, 2025
19 checks passed
@jfreden jfreden deleted the fix_fileservice_race_condition branch May 26, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] FileSettingsServiceIT testSymlinkUpdateTriggerReload failing
3 participants