Skip to content

[9.0] Use new source loader when lower docId is accessed (#128320) #128409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Open

[9.0] Use new source loader when lower docId is accessed (#128320) #128409

wants to merge 1 commit into from
+127 −0

Conversation

parkertimmins
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

@parkertimmins
Use new source loader when lower docId is accessed (elastic#128320)
85ffeec 
When using synthetic source, runtime fields data may come from doc values. Doc values iterators can only be read once, and in increasing docId order. But if a runtime field is referenced multiple times in a query, currently the same doc value iterator will be used. This causes an error, as the second field reference will attempt to read the same iterator from a lower docId than was previously used. The fix is to create a new source loader, and thus a new doc value iterator, if the requested docId is lower than the last seen docId.

(cherry picked from commit 51e87cb)

# Conflicts:
#	server/src/main/java/org/elasticsearch/search/lookup/ConcurrentSegmentSourceProvider.java
@parkertimmins parkertimmins mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport v9.0.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parkertimmins @elasticsearchmachine