Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 23, 2025

I'd made a mistake in #136327 when writing the test for fetching fields that the release of 9.2.0 revealed. This fixes it and adds one more test that we needed from #136327.

I'd made a mistake in elastic#136327 when writing the test for fetching fields
that the release of 9.2.0 revealed. This fixes it and adds one more test
that we needed from elastic#136327.
@nik9000 nik9000 requested a review from alex-spies October 23, 2025 21:16
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build :Analytics/ES|QL AKA ESQL v9.2.1 v9.3.0 labels Oct 23, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nik! Looks good, just minor comments.

yield equalTo("aggregate_metric_double");
}
case DENSE_VECTOR -> {
logger.error("ADFDAFAF " + minVersion());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup. will zap

Map<String, Object> response;
try {
String request = """
| EVAL strjunk = TO_STRING(f_aggregate_metric_double)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? There's more junk below to trigger the workaround, and this is not kept.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave a comment - yeah, it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.2.1 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants