Allow QueryRewriteContext to perform async actions on remote clusters #138124
+475
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
>non-issue
:SearchOrg/Relevance
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
elasticsearchmachine
added
v9.3.0
Team:Search - Relevance
Mikep86
commented
Nov 14, 2025
Comment on lines
+418
to
+419
| // TODO: Need to make a copy of remoteAsyncActions? | ||
| for (var entry : remoteAsyncActions.entrySet()) { |
Contributor
Author
There was a problem hiding this comment.
I see that asyncActions is copied to prevent concurrent modification. Do we need to do the same for remoteAsyncActions?
Mikep86
commented
Nov 14, 2025
|
|
||
| RemoteClusterClient remoteClient = client.getRemoteClusterClient( | ||
| clusterAlias, | ||
| client.threadPool().executor(SEARCH_COORDINATION), // TODO: Is this the right thread pool for remote async actions? |
Contributor
Author
There was a problem hiding this comment.
SEARCH_COORDINATION was my best guess, LMK if there's a more appropriate thread pool to use.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods to
QueryRewriteContextfor registering and executing remote cluster async actions as part of the query rewrite process.This functionality will be used by the
semanticand intercepted (match/sparse_vector/knn) queries to get remote cluster inference results when performing CCS withccs_minimize_roundtrips=false. It will also be used by the simplifiedlinear/rrfretrievers to handle CCS. See the semantic search CCS POC for more context.Both of these use cases will be implemented in follow-up PRs.