Skip to content

[8.19] rest-api-spec: fix required annotations (#138147) #139352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pquentin wants to merge 1 commit into
base: 8.19
Choose a base branch
from
Open

[8.19] rest-api-spec: fix required annotations (#138147) #139352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions rest-api-spec/src/main/resources/rest-api-spec/api/indices.downsample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@
"parts": {
"index": {
"type": "string",
"description": "The index to downsample",
"required": true
"description": "The index to downsample"
},
"target_index": {
"type": "string",
"description": "The name of the target index to store downsampled data",
"required": true
"description": "The name of the target index to store downsampled data"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions ...pi-spec/src/main/resources/rest-api-spec/api/ml.clear_trained_model_deployment_cache.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"parts": {
"model_id": {
"type": "string",
"description": "The unique identifier of the trained model.",
"required": true
"description": "The unique identifier of the trained model."
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions rest-api-spec/src/main/resources/rest-api-spec/api/ml.infer_trained_model.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"parts": {
"model_id": {
"type": "string",
"description": "The unique identifier of the trained model.",
"required": true
"description": "The unique identifier of the trained model."
}
}
},
Expand Down
3 changes: 1 addition & 2 deletions rest-api-spec/src/main/resources/rest-api-spec/api/ml.start_trained_model_deployment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"parts": {
"model_id": {
"type": "string",
"description": "The unique identifier of the trained model.",
"required": true
"description": "The unique identifier of the trained model."
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions rest-api-spec/src/main/resources/rest-api-spec/api/ml.stop_trained_model_deployment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"parts": {
"model_id": {
"type": "string",
"description": "The unique identifier of the trained model.",
"required": true
"description": "The unique identifier of the trained model."
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions rest-api-spec/src/main/resources/rest-api-spec/api/monitoring.bulk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,17 @@
"params": {
"system_id": {
"type": "string",
"required": true,
"description": "Identifier of the monitored system"
},
"system_api_version": {
"type": "string",
"required": true,
"description": "API Version of the monitored system"
},
"interval": {
"type": "string",
"required": true,
"description": "Collection interval (e.g., '10s' or '10000ms') of the payload"
}
},
Expand Down
1 change: 0 additions & 1 deletion rest-api-spec/src/main/resources/rest-api-spec/api/transform.schedule_now_transform.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"parts": {
"transform_id": {
"type": "string",
"required": true,
"description": "The id of the transform."
}
}
Expand Down
1 change: 0 additions & 1 deletion rest-api-spec/src/main/resources/rest-api-spec/api/transform.update_transform.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"parts": {
"transform_id": {
"type": "string",
"required": true,
"description": "The id of the transform."
}
}
Expand Down
30 changes: 0 additions & 30 deletions x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/monitoring/bulk/10_basic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,36 +139,6 @@

- match: { hits.total: 0 }

# Missing a system_id causes it to fail
- do:
catch: bad_request
monitoring.bulk:
system_api_version: "7"
interval: "10s"
body:
- '{"index": {"_type": "default_type"}}'
- '{"field_1": "value_1"}'

# Missing a system_api_version causes it to fail
- do:
catch: bad_request
monitoring.bulk:
system_id: "kibana"
interval: "10s"
body:
- '{"index": {"_type": "default_type"}}'
- '{"field_1": "value_1"}'

# Missing an interval causes it to fail
- do:
catch: bad_request
monitoring.bulk:
system_id: "kibana"
system_api_version: "7"
body:
- '{"index": {"_type": "default_type"}}'
- '{"field_1": "value_1"}'

---
"Bulk indexing of monitoring data on closed indices should throw an export exception":
- skip:
Expand Down