Rename SemanticTextIndexOptions to SemanticIndexOptions#152942
Merged
kkharbas merged 3 commits intoJul 7, 2026
Conversation
The class is shared by both semantic and semantic_text field mappers, so its name should not be scoped to semantic_text alone.
elasticsearchmachine
added
v9.5.0
needs:triage
davidkyle
added
>refactoring
:Search Relevance/Search
elasticsearchmachine
added
needs:triage
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
removed
the
needs:triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SemanticTextIndexOptionsis shared by bothSemanticFieldMapper(thesemanticfield type) andSemanticTextFieldMapper(thesemantic_textfield type), so scoping the name tosemantic_textalone is misleading.SemanticIndexOptionsand updates all usages and comments accordingly.