Upgrade to Jackson 2.7.1 #16801
Merged
Upgrade to Jackson 2.7.1 #16801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbertouch thanks for the PR! I think we may want to bump it to Jackson 2.7.1 while we're at it: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.7.1 Do you want to make that change? |
|
Hi @dakrone, done! |
|
@jbertouch thanks, for these we also need to run |
|
Hi @dakrone, I ran the task and committed the updated hash values. |
|
Merged, thanks @jbertouch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16294.
The previous duplicate key test assertion in JsonSettingsLoaderTests was failing to catch the exception. The background - Jackson 2.7.0 altered the logic for the getTokenLocation method in the JSON parser, it now points to the first character that is logically part of the token. See FasterXML/jackson-core#229.