Fix date and ip sources in the composite aggregation #29370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the formatting of the values in the composite aggregation response. `date` fields should return timestamp as longs when used in a `terms` source and `ip` fields should always be formatted as strings. This commit also fixes the parsing of the `after` key for these field types. Finally, this commit disables the index optimization for the `ip` field and any source that provides a `missing` value.
|
Pinging @elastic/es-search-aggs |
jpountz
approved these changes
Apr 5, 2018
| final DocValueFormat format; | ||
| if (format() == null && fieldType instanceof DateFieldMapper.DateFieldType) { | ||
| // defaults to the raw format on date fields (preserve timestamp as longs). | ||
| format = DocValueFormat.RAW; |
There was a problem hiding this comment.
why shouldn't we use the format from the mapping?
There was a problem hiding this comment.
That's a good question. In 6.2 we always return the raw value and there is no distinction in this aggregation to return getKey or getKeyAsString since the returned object is a map. So I think it's preferable to return the raw value unless a format has been specified.
There was a problem hiding this comment.
I see. for the record we'll probably need to change this anyway one day for #18518
jimczi
added a commit
that referenced
this pull request
Apr 9, 2018
This commit fixes the formatting of the values in the composite aggregation response. `date` fields should return timestamp as longs when used in a `terms` source and `ip` fields should always be formatted as strings. This commit also fixes the parsing of the `after` key for these field types. Finally, this commit disables the index optimization for the `ip` field and any source that provides a `missing` value.
|
This is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the formatting of the values in the composite aggregation response.
datefields should return timestamp as longs when used in atermssource andipfields should always be formatted as strings.This commit also fixes the parsing of the
afterkey for these field types.Finally, this change disables the index optimization for the
ipfield and any source that provides amissingvalue.