Skip to content

TSDB: fix time series field caps bwc yaml test #89236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

TSDB: fix time series field caps bwc yaml test #89236

merged 1 commit into from
Aug 15, 2022

Conversation

weizijun
Copy link
Contributor

This PR fix the issue #89171
When add index.mode = time_series, the minimum version is 8.1.0. So I change the skip version config.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v8.5.0 labels Aug 10, 2022
@weizijun weizijun mentioned this pull request Aug 10, 2022
Closed
@salvatore-campagna salvatore-campagna added >test-failure Triaged test failures from CI :StorageEngine/TSDB You know, for Metrics and removed needs:triage Requires assignment of a team area label labels Aug 11, 2022
@salvatore-campagna salvatore-campagna self-assigned this Aug 11, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 11, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

droberts195
droberts195 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @weizijun. I'll merge this as a way to mute the failing test, although I think there might still be more for @elastic/es-analytics-geo to consider which I'll comment on in #89171.

@droberts195 droberts195 merged commit 104ad7f into elastic:main Aug 15, 2022
@csoulios
Copy link
Contributor

csoulios commented Aug 15, 2022 •
edited
Loading

Thanks for submitting the fix @weizijun.

Also, @droberts195 thank you for reviewing and merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees

@salvatore-campagna salvatore-campagna

Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weizijun @elasticsearchmachine @csoulios @droberts195 @salvatore-campagna