Restrict the priority of ShardSnapshotTask to the same snapshot only
#89976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @pxsalehi, I've created a changelog YAML for you. |
original-brownbear
approved these changes
Sep 10, 2022
|
CI failure was due to #89776 and unrelated. |
|
@elasticmachine update branch |
|
merge conflict between base and head |
…ve-compare-shardSnapshot
…com:pxsalehi/elasticsearch into ps-220909-alternative-compare-shardSnapshot
|
@elasticmachine run elasticsearch-ci/bwc |
|
Thanks, Armin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give shard snapshot metadata work priority over file snapshot work ONLY within the same snapshot. After some discussion with Armin and some benchmarks, this seems to prevent many overlapping snapshots prolonging each other due to constant prioritization of snapshot metadata work.