Skip to content

Conversation

@saikatsarkar056
Copy link
Contributor

@saikatsarkar056 saikatsarkar056 commented Nov 14, 2025

Summary

Screen.Recording.2025-11-14.at.11.46.59.AM.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner November 14, 2025 18:44
@saikatsarkar056 saikatsarkar056 marked this pull request as draft November 14, 2025 19:31
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout: [ platform / kbn-streamlang-tests ] package / serverless-oblt - Cross-compatibility - Date Processor - should use a different output format
  • [job] [logs] Scout: [ platform / kbn-streamlang-tests ] package / should use a different output format

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchGettingStarted 267 268 +1
searchHomepage 254 255 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-code-examples 9 12 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchGettingStarted 155.1KB 155.8KB +663.0B
searchHomepage 148.8KB 149.4KB +659.0B
total +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchGettingStarted 6.5KB 6.5KB +1.0B
searchHomepage 7.2KB 7.2KB +2.0B
total +3.0B
Unknown metric groups

API count

id before after diff
@kbn/search-code-examples 9 16 +7

@wildemat
Copy link
Contributor

I like this approach! I had seen Monaco's linkProvider before which uses regex to flag strings as clickable links.
If we provide the app's base url as the regex, it could be a nice way to allow for any internal links to be clicked without requiring them to be hardcoded.

E.g. vibecoded sandbox: https://codesandbox.io/p/sandbox/vnrc53
API: https://microsoft.github.io/monaco-editor/typedoc/functions/languages.registerLinkProvider.html

See if it's worth trying out or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants