Skip to content

[dashboards as code] remove content management #243093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 17, 2025
Merged

[dashboards as code] remove content management #243093

merged 9 commits into from
Nov 17, 2025

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Nov 14, 2025 •
edited
Loading

Closes #238500
Closes #241368
Closes #240161

PR decouples GET endpoint from content management. PR then removes content management since routes are no longer using it.

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 15, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 17, 2025

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review November 17, 2025 13:39
@nreese nreese requested review from a team as code owners November 17, 2025 13:39
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Dashboards API v9.3.0 labels Nov 17, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 17, 2025

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl self-requested a review November 17, 2025 13:40
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 17, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 777 776 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 98 103 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 663.2KB 663.4KB +211.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 18.1KB 17.6KB -485.0B
Unknown metric groups

API count

id before after diff
dashboard 100 105 +5

History

kowalczyk-krzysztof
kowalczyk-krzysztof approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SharedUX code changes LGTM

nickpeihl
nickpeihl approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one question about constants.

code review and tested updated endpoints.

src/platform/plugins/shared/dashboard/common/page_bundle_constants.ts
export const LANDING_PAGE_PATH = '/list';
export const DASHBOARD_APP_ID = 'dashboards';
export const SEARCH_SESSION_ID = 'searchSessionId';
export const DASHBOARD_GRID_COLUMN_COUNT = 48;
Copy link
Member

@nickpeihl nickpeihl Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm fully understanding the constants separation here. I'm guessing these constants are expected to be in the public bundle as opposed to server-only. But then shouldn't the DEFAULT_PANEL_WIDTH, DEFAULT_PANEL_HEIGHT, and DEFAULT_DASHBOARD_OPTIONS constants be here since they are also used in the public bundle?

Copy link
Contributor Author

@nreese nreese Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one file is included in plugin page load. The other file, is async loaded when dashboard application is loaded. The split avoids putting constants into page load that are not needed.

src/platform/plugins/shared/dashboard/server/content_management/v1/schema/index.ts
*/

export * from './get';
export * from './common';
Copy link
Member

@nickpeihl nickpeihl Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit exports! 💯

@nreese nreese merged commit 2f551ba into elastic:main Nov 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@kowalczyk-krzysztof kowalczyk-krzysztof kowalczyk-krzysztof approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Project:Dashboards API release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dashboards as code] Decouple from content management [Dashboards as Code] Rename namespaces [Dashboards as code] Use REST endpoints in client

5 participants

@nreese @elasticmachine @nickpeihl @kowalczyk-krzysztof @kibanamachine