Skip to content

Log warning on BadRequestError#2039

Merged
jordan-powers merged 1 commit intoelastic:masterfrom
jordan-powers:warn-on-bad-request
Feb 23, 2026
Merged

Log warning on BadRequestError#2039
jordan-powers merged 1 commit intoelastic:masterfrom
jordan-powers:warn-on-bad-request

Conversation

@jordan-powers
Copy link
Copy Markdown
Contributor

This PR updates the Retry runner to log a warning message when a delegate runner raises an elasticsearch.BadRequestError.

I was recently experimenting with a change to the elastic/logs track, and I spent several hours debugging why the validate-package-template-installation step was failing. It turns out I had a typo in my changes to one of the component index templates, but the bad request was being silently ignored. This PR should hopefully make it much easier to debug similar issues.

@gbanasiak gbanasiak requested a review from a team February 19, 2026 10:51
Copy link
Copy Markdown
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordan-powers jordan-powers merged commit 517628d into elastic:master Feb 23, 2026
15 checks passed
slDias pushed a commit to slDias/rally-fork that referenced this pull request Feb 26, 2026
This PR updates the Retry runner to log a warning message when a delegate
runner raises an `elasticsearch.BadRequestError`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants