-
Notifications
You must be signed in to change notification settings - Fork 105
[ResponseOps] Maintenance Window Resource #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
func ResourceMaintenanceWindow() *schema.Resource { | ||
apikeySchema := map[string]*schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this wasn't generated but implemented by you. If so, couldn't this be generated based on the OAS files we create on the Kibana side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generation is only for the API client, so the resource specification is usually done manually. Maybe there is a way but I don't think we use it in this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashicorp have an openapi generator which builds a schema based on a set of openapi routes. It's not used in this project yet, but we're using it to help with Serverless project resources. It's... ok, but has some limitations to deal with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to use the consolidated kibana spec for this new resource rather than on the older alerting client?
return nil | ||
} | ||
|
||
func ResourceMaintenanceWindow() *schema.Resource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rebuild this as a plugin-framework based resource (data view as an example). It automatically solves a bunch of TF related limitations, and should be the future for any new work in the provider.
} | ||
|
||
func ResourceMaintenanceWindow() *schema.Resource { | ||
apikeySchema := map[string]*schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashicorp have an openapi generator which builds a schema based on a set of openapi routes. It's not used in this project yet, but we're using it to help with Serverless project resources. It's... ok, but has some limitations to deal with.
Closes #197021
Summary
The response-ops team has been working on a public maintenance window API.
Most of the work is done and the feature should be available for v9.1.0. (Feature branch PR)
This PR enables users to define maintenance windows tf resources.
Testing
The server version needs to be
>=9.1.0
so on all the tests I have been using the maintenance window API feature branch.I built it locally and ran
testacc
or Terraform commands.What would the proper procedure be to deploy this change?
Example resource