Skip to content

feat(agents-mobile): add Delete account button#4428

Merged
kevin-dp merged 1 commit into
mainfrom
kevin/agents-mobile-delete-account-button
May 29, 2026
Merged

feat(agents-mobile): add Delete account button#4428
kevin-dp merged 1 commit into
mainfrom
kevin/agents-mobile-delete-account-button

Conversation

@kevin-dp

Copy link
Copy Markdown
Contributor

Summary

Why

Google Play's account-deletion policy (https://support.google.com/googleplay/android-developer/answer/13327111) requires both an in-app option and a publicly accessible web URL describing the process. The web page alone won't pass review.

UI placement

Sits below the existing Account / Workspaces / Open dashboard / Sign out card, in its own "Delete account" section with explanatory copy that the button just opens instructions — it doesn't perform the deletion directly. Uses the ghost button variant to visually de-emphasize it relative to the primary actions.

Test plan

  • pnpm --filter @electric-ax/agents-mobile run typecheck
  • Open the Account screen while signed in → "Delete account" section appears below the main card with the explanatory text + ghost button.
  • Tap "Delete account…" → system browser opens to https://electric-sql.com/about/legal/delete-account.
  • Open the Account screen while signed out → section is hidden (sign-in buttons shown instead, as before).

Depends on

🤖 Generated with Claude Code

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.41%. Comparing base (1c6ebf9) to head (c7b655e).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4428       +/-   ##
===========================================
+ Coverage   56.19%   85.41%   +29.22%     
===========================================
  Files         262        2      -260     
  Lines       26571       48    -26523     
  Branches     7094       11     -7083     
===========================================
- Hits        14932       41    -14891     
+ Misses      11635        7    -11628     
+ Partials        4        0        -4     
Flag Coverage Δ
packages/agents ?
packages/agents-mcp ?
packages/agents-mobile 85.41% <ø> (ø)
packages/agents-runtime ?
packages/agents-server-ui ?
packages/electric-ax ?
packages/experimental ?
packages/react-hooks ?
packages/start ?
packages/typescript-client ?
packages/y-electric ?
typescript 85.41% <ø> (+29.22%) ⬆️
unit-tests 85.41% <ø> (+29.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Electric Agents Mobile Build

Android preview build for commit c7b655e.

Platform Profile Status Build
Android preview Passed EAS build

Workflow run

@samwillis samwillis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-dp kevin-dp force-pushed the kevin/agents-mobile-delete-account-button branch from 5f3f5f2 to 025f810 Compare May 29, 2026 08:42
Adds an in-app "Delete account" entry point on the Account screen
(visible when signed in to Electric Cloud). Tapping it opens
https://electric-sql.com/about/legal/delete-account in the system
browser, where the user can read what gets deleted, what may be
retained, and email support to start the request.

Required for Google Play submission — Google's account-deletion
policy requires both an in-app option and a publicly accessible web
URL describing the process.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kevin-dp kevin-dp force-pushed the kevin/agents-mobile-delete-account-button branch from 025f810 to c7b655e Compare May 29, 2026 08:59
@kevin-dp kevin-dp merged commit acad656 into main May 29, 2026
19 checks passed
@kevin-dp kevin-dp deleted the kevin/agents-mobile-delete-account-button branch May 29, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants