Skip to content

Capture Codex reasoning summaries#4617

Merged
samwillis merged 2 commits into
mainfrom
fix-codex-reasoning-summaries
Jun 18, 2026
Merged

Capture Codex reasoning summaries#4617
samwillis merged 2 commits into
mainfrom
fix-codex-reasoning-summaries

Conversation

@KyleAMathews

Copy link
Copy Markdown
Contributor

Summary

  • request OpenAI/Codex reasoning summaries by default when enabling reasoning effort
  • preserve explicit reasoning summary settings from caller payloads
  • add adapter coverage proving streamed thinking events are written as entity reasoning rows/deltas

Verification

  • cd packages/agents-runtime && pnpm exec vitest run test/pi-adapter.test.ts
  • cd packages/agents && pnpm exec vitest run test/model-catalog.test.ts

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Electric Agents Desktop Builds

Build artifacts for commit aa0381e.

Platform Status Artifact
macOS Apple Silicon Passed DMG
macOS Intel Passed DMG
Windows x64 Passed Installer
Linux x64 Passed AppImage / deb

Workflow run

@KyleAMathews KyleAMathews requested a review from kevin-dp June 17, 2026 17:06
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Electric Agents Mobile Build

Local mobile checks ran for commit aa0381e.

The EAS Android preview build was skipped because the mobile-eas-build label is not present.
Add the mobile-eas-build label to this PR to produce an installable preview build.

Workflow run

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.71%. Comparing base (8f4368d) to head (aa0381e).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/agents/src/model-catalog.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4617      +/-   ##
==========================================
+ Coverage   57.56%   57.71%   +0.15%     
==========================================
  Files         342      342              
  Lines       39993    40009      +16     
  Branches    11633    11661      +28     
==========================================
+ Hits        23023    23093      +70     
+ Misses      16933    16879      -54     
  Partials       37       37              
Flag Coverage Δ
packages/agents 72.96% <93.75%> (+0.21%) ⬆️
packages/agents-mobile 80.67% <ø> (ø)
packages/agents-runtime 83.38% <ø> (+0.41%) ⬆️
packages/agents-server 75.29% <ø> (-0.25%) ⬇️
packages/agents-server-ui 7.51% <ø> (ø)
packages/electric-ax 47.62% <ø> (ø)
typescript 57.71% <93.75%> (+0.15%) ⬆️
unit-tests 57.71% <93.75%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevin-dp kevin-dp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a changeset but otherwise good to go.

KyleAMathews and others added 2 commits June 18, 2026 11:06
@samwillis samwillis force-pushed the fix-codex-reasoning-summaries branch from 7c8eb12 to aa0381e Compare June 18, 2026 10:13
@samwillis samwillis merged commit ac2391d into main Jun 18, 2026
42 checks passed
@samwillis samwillis deleted the fix-codex-reasoning-summaries branch June 18, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants