Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-update powershell script requires reset of PSModulePath #8047

Closed
wants to merge 35 commits into from

Conversation

mmaietta
Copy link
Collaborator

Fixes: #7127

Also implements additional unit tests, signature verification, and error handling for linux auto-update.

Adds new event to auto-update flow "before-quit-for-update"

Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: 63554d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 63554d7
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65cabe56f300790008f08c3f
😎 Deploy Preview https://deploy-preview-8047--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -57,7 +61,10 @@
upgradePath,
]
}
this.spawnSyncLog(sudo, [`${wrapper}/bin/bash`, "-c", `'${cmd.join(" ")}'${wrapper}`])
const { stderr } = this.spawnSyncLog(sudo, [`${wrapper}/bin/bash`, "-c", `'${cmd.join(" ")}'${wrapper}`])

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

This shell argument which depends on [library input](1) is later used in a [shell command](2). This shell argument which depends on [library input](3) is later used in a [shell command](2). This shell argument which depends on [library input](4) is later used in a [shell command](2). This shell argument which depends on [library input](5) is later used in a [shell command](2). This shell argument which depends on [library input](6) is later used in a [shell command](2). This shell argument which depends on [library input](7) is later used in a [shell command](2). This shell argument which depends on [library input](8) is later used in a [shell command](2).
@mmaietta mmaietta closed this Feb 14, 2024
@mmaietta
Copy link
Collaborator Author

Closing in favor of #8051

@mmaietta mmaietta deleted the fix/absolute-path-nsexec branch September 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto update failed while executing the powershell command
1 participant