refactor: change quitAndInstall to asynchronous to prevent blocking main thread while updating#8405
refactor: change quitAndInstall to asynchronous to prevent blocking main thread while updating#8405xyloflake wants to merge 7 commits intoelectron-userland:masterfrom
Conversation
modified quitAndInstall from synchronous to asynchronous to prevent blocking the event loop during updates. This change enhances the application's responsiveness by allowing other tasks to proceed while the update is being processed. BREAKING CHANGE: The quitAndInstall function is now asynchronous, which may require updates to the calling code to handle promises.
This reverts commit d6031ee.
🦋 Changeset detectedLatest commit: 2960b76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mmaietta here's the PR but I need help for testing this. Labelled as I have not tested on any single platform and this time I'll need you to help me with this :) What I also mean to imply is I've just written the code, have not built or anything. |
|
@mmaietta I just checked out the PR on NSIS and no, quitAndInstall does NOT work. It says the update will be installed after quit but it never gets updated. So I'm converting this to a draft PR |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
right, i don't have the time to work on this currently (hopefully within 2 months i make out some time for this) |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
1 participant
No description provided.