Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete all old node module collector and legacy nativeRebuilder (BREAKING) #8889

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

beyondkmp
Copy link
Collaborator

Now that the new Node module collector is released, we can delete these old commands.

After deletion, it will completely replace the Node collector inside app-builder-bin. The next step is to replace some other commands until all are fully replaced.

Copy link

changeset-bot bot commented Feb 22, 2025

🦋 Changeset detected

Latest commit: 5180526

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
electron-builder Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@beyondkmp beyondkmp marked this pull request as draft February 22, 2025 07:32
@beyondkmp beyondkmp marked this pull request as ready for review February 22, 2025 08:04
@beyondkmp beyondkmp requested a review from mmaietta February 22, 2025 08:04
@mmaietta mmaietta changed the title chore: delete all old node module collector and legacy nativeRebuilder chore: delete all old node module collector and legacy nativeRebuilder (BREAKING) Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants