Skip to content

fix: find cwd using getProjectRootPath for detecting package manager#8941

Merged
mmaietta merged 2 commits intomasterfrom
fix/detect-yarn-PM
Mar 7, 2025
Merged

fix: find cwd using getProjectRootPath for detecting package manager#8941
mmaietta merged 2 commits intomasterfrom
fix/detect-yarn-PM

Conversation

@mmaietta
Copy link
Copy Markdown
Collaborator

@mmaietta mmaietta commented Mar 6, 2025

Fixes: #8938

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 2f2833c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta marked this pull request as ready for review March 6, 2025 02:43
beyondkmp
beyondkmp previously approved these changes Mar 6, 2025
@beyondkmp
Copy link
Copy Markdown
Contributor

beyondkmp commented Mar 6, 2025

There is an error on Windows, and the error message is as follows:

image

We should also fix it together.

packages/app-builder-lib/src/node-module-collector/packageManager.ts
image
image

@beyondkmp
Copy link
Copy Markdown
Contributor

LGTM

@mmaietta mmaietta merged commit 14b96df into master Mar 7, 2025
@mmaietta mmaietta deleted the fix/detect-yarn-PM branch March 7, 2025 14:04
@github-actions github-actions Bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on Monorepo with "workspace:^" dependencies after switch to "node-module-collector"

2 participants