Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update @electron/universal to v2.0.2 #8967

Conversation

t3chguy
Copy link
Contributor

@t3chguy t3chguy commented Mar 17, 2025

Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: 7d8417e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@t3chguy t3chguy changed the title Bump @electron/universal to fix asar integrity with multiple ASARs chore(deps): update @electron/universal to v2.0.2 Mar 17, 2025
@t3chguy
Copy link
Contributor Author

t3chguy commented Mar 17, 2025

Feel free to replace this with a Renovate PR - I can see it pending in #6183

@t3chguy
Copy link
Contributor Author

t3chguy commented Mar 17, 2025

Actually looks like this won't be trivial https://github.com/element-hq/element-desktop/actions/runs/13901099419/job/38892848894?pr=2169 - electron/universal#130 may be a new regression in that version

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 17, 2025

@t3chguy your second issue you linked might be resolved with my other PR electron/universal#126

@t3chguy
Copy link
Contributor Author

t3chguy commented Mar 17, 2025

@mmaietta does seem that way, in which case I advise against upgrading to 2.0.2 and awaiting that fix. I will reopen this once that has landed.

@t3chguy t3chguy closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants