refactor: Add ElectronBrowserContext::BrowserContexts()
#46089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
ckerr
added
target/34-x-y
ckerr
force-pushed
the
refactor/ElectronBrowserContext.BrowserContexts
branch
from
2d1f658 to
1e44ee8
Compare
codebytere
changed the title
ElectronBrowserContext::BrowserContexts()
…owserMainParts::PostMainMessageLoopRun()
…tensionsBrowserClient::IsValidContext()
…tensionsBrowserClient::BroadcastEventToRenderers()
decouple ElectronExtensionsBrowserClient from the internals of ElectronBrowserContext
ckerr
force-pushed
the
refactor/ElectronBrowserContext.BrowserContexts
branch
from
1e44ee8 to
b1fc0ef
Compare
|
No Release Notes |
|
I was unable to backport this PR to "35-x-y" cleanly; |
trop
bot
added
needs-manual-bp/35-x-y
and removed
target/35-x-y
This was referenced Mar 20, 2025
|
I have automatically backported this PR to "36-x-y", please check out #46158 |
trop
bot
added
in-flight/36-x-y
and removed
target/36-x-y
|
I have automatically backported this PR to "34-x-y", please check out #46159 |
trop
bot
added
in-flight/34-x-y
and removed
target/34-x-y
trop
bot
added
in-flight/35-x-y
merged/36-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is to tighten down controls on how
ElectronBrowserContextis accessed and to reduce leaking implementation details. Callers should not have mutable access to the context map. Callers shouldn't even need to know the context map exists 🙂Checklist
npm testpassesRelease Notes
Notes: none.