-
Notifications
You must be signed in to change notification settings - Fork 185
feat: add preamble to blog page #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add preamble to blog page #857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the changes to .sha
, package-lock.json
, and yarn.lock
hey @erickzhao , This was my first PR and I mistakenly included changes to to .sha, yarn.lock, and package-lock.json thinking they were necessary, It happened due to running 'npm install' command instead of 'yarn'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GauravKumar17, can you explain why there are so many new files added in this PR?
@dsanders11 Thanks for reviewing ! I understand it might look a large addition but after hours of here and there , I came to this solution. |
Hey @dsanders11 , don't mind asking but is their any mistake in the PR? If you just give me a review, I will be happy with the learning. |
Description of Change
Added a warning preamble to the blog post which are more than a year old.
This helps the reader to know that some information on the blog may be outdated.
Main changes are in :
src/theme/BlogPostItem/index.tsx
src/css/custom.scss
Note- Please feel free to review and correct my mistakes, this was my life's first PR.
Checklist
Dark Mode
Light Mode
Closes #857