ci: change automated docs update to use PRs #868
Conversation
Deploying electron-website with
|
| Latest commit: |
d56b4e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d229e91.electron-website.pages.dev |
| Branch Preview URL: | https://ci-automated-update-pr.electron-website.pages.dev |
dsanders11
force-pushed
the
ci/automated-update-pr
branch
from
c9201ff to
ecd4f54
Compare
.github/workflows/update-docs.yml
Outdated
| run: | | ||
| PR_NUMBER=$(gh pr list --head "docs/update-to-${SHA}" --json number --jq '.[0].number') | ||
| gh pr review ${PR_NUMBER} --approve | ||
| gh pr merge ${PR_NUMBER} --auto --squash |
There was a problem hiding this comment.
I think we need a "wait for checks" step here that waits up to ~20 minutes for required CI to pass?
More ideally it would fire a separate job once PR enters "mergable" state. But for now whack a while !status_passed kinda loop for fun will get us unblocked I think
There was a problem hiding this comment.
I think the --auto flag should handle this for us? From the gh CLI docs: "Automatically merge only after necessary requirements are met".
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh pr review "docs/update-to-${SHA}" --approve |
There was a problem hiding this comment.
Naive question: would this be a self-approve and then not count for the purposes of mergeability?
There was a problem hiding this comment.
There's a subtle difference here (which I could call out better in the code with a comment), but we're using secrets.GITHUB_TOKEN here so it'll be the default GitHub Actions app approving the PR, which was opened by our GitHub app.
3 participants
Description of Change
We have some required status checks now which require a PR, and that's breaking our existing automation solution of pushing straight to
main. Run everything through a PR which the existing GitHub app will create, and then use the generic GitHub Actions app to approve and merge the PR.Checklist