Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Element Call to be consumed as a package within a larger app #2922

Closed
wants to merge 6 commits into from

Conversation

robintown
Copy link
Member

@robintown robintown commented Jan 3, 2025

If we want to add Element Call as a dependency of Element Web and package it with the application, we should make yarn pack produce a built copy. Then it can be added as a simple Git dependency to projects using any modern package manager like Yarn Berry or NPM, and it will be saved and built in the local package cache.

Unfortunately, we don't use modern package managers yet for our web applications, we use Yarn Classic. This is in draft while I ask around about whether now is a good time to change that.

Part of element-hq/element-web#23908

@hughns
Copy link
Member

hughns commented Feb 18, 2025

I've been cribbing bits of this for #2994 and some bits have already landed.

Things I've done:

  • using --frozen-lockfile in CI
  • using the embedded approach that you took and relocating index.html

The one thing I haven't used is the build during yarn install. Instead we only need to do a build for releases of Element Call.

Thank you!

@hughns hughns closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants