Fix stale action not closing issues as expected #27972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so that actions/stale@v9 can delete caches. Without this permisson, the cache is never deleted leading to some issues never being checked again.
florianduros
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stale action uses cache to keep track of issues it has already processed. This cache is supposed to be deleted at the end of the run but it never happens due to a lack of permission. See https://github.com/element-hq/element-web/actions/runs/10588795861/job/29341882041#step:2:7046
The end result of this is that some issues are just never considered for closing once they're in the cache.
Relevant:
actions/stale#1131 (comment)