-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the strings for out of sync Key Storage. #3468
Conversation
Generated by 🚫 Danger Swift against f5ccb2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It looks great to me.
…e place as Android.
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3468 +/- ##
========================================
Coverage 77.86% 77.87%
========================================
Files 744 744
Lines 61401 61416 +15
========================================
+ Hits 47809 47825 +16
+ Misses 13592 13591 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is an initial part of #3399 to get the strings in sync with everything done for element-hq/element-meta#2590. I've tweaked the banner a bit too to match the Figma, preparing it for the secondary button to be added.
Unfortunately it looks like updated flows will require somewhat of a re-write so this will be handled separately, likely after the next RC.