Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the strings for out of sync Key Storage. #3468

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

pixlwave
Copy link
Member

This PR is an initial part of #3399 to get the strings in sync with everything done for element-hq/element-meta#2590. I've tweaked the banner a bit too to match the Figma, preparing it for the secondary button to be added.

Unfortunately it looks like updated flows will require somewhat of a re-write so this will be handled separately, likely after the next RC.

Screenshot 2024-10-31 at 10 15 49 am

@pixlwave pixlwave requested a review from a team as a code owner October 31, 2024 10:16
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 31, 2024 10:16
@pixlwave pixlwave added the pr-misc for other changes label Oct 31, 2024
@pixlwave pixlwave requested review from manuroe and removed request for Velin92 October 31, 2024 10:17
Copy link

github-actions bot commented Oct 31, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f5ccb2e

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It looks great to me.

Copy link

sonarcloud bot commented Oct 31, 2024

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (6f15826) to head (f5ccb2e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...creen/SecureBackupRecoveryKeyScreenViewModel.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3468   +/-   ##
========================================
  Coverage    77.86%   77.87%           
========================================
  Files          744      744           
  Lines        61401    61416   +15     
========================================
+ Hits         47809    47825   +16     
+ Misses       13592    13591    -1     
Flag Coverage Δ
unittests 69.51% <90.90%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 0da2252 into develop Oct 31, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/key-storage-out-of-sync-strings branch October 31, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants