Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow importing existing users when the localpart matches in upstream OAuth 2.0 logins #4193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow importing existing users when the localpart matches in upstream OAuth 2.0 logins #4193

wants to merge 1 commit into from

Conversation

mcalinghee
Copy link

@mcalinghee mcalinghee commented Mar 11, 2025 •
edited
Loading

Fixes Point 4 in #2089

import the link without overriding existing links for this user (corresponds to allow_existing_users: true in Synapse)

  • by-pass localpart existence validation when linking an existing account if allow_existing_users : true
  • by-pass localpart availability against homeserver validation when linking an existing account if allow_existing_users : true

@mcalinghee mcalinghee changed the title Allow existing user wip: allow existing user Mar 11, 2025
@mcalinghee mcalinghee force-pushed the feat/allow_override_user branch 6 times, most recently from 9d35eeb to d50b6c0 Compare March 12, 2025 16:20
@mcalinghee mcalinghee changed the title wip: allow existing user allow importing existing users when the localpart matches in upstream OAuth 2.0 logins Mar 12, 2025
@mcalinghee mcalinghee marked this pull request as ready for review March 12, 2025 16:21
@mcalinghee mcalinghee mentioned this pull request Mar 12, 2025
Open
@mcalinghee mcalinghee force-pushed the feat/allow_override_user branch from d50b6c0 to 405abce Compare March 12, 2025 16:47
@mcalinghee mcalinghee marked this pull request as draft March 12, 2025 16:52
@mcalinghee mcalinghee force-pushed the feat/allow_override_user branch from 405abce to 11f17cc Compare March 12, 2025 17:18
@mcalinghee mcalinghee marked this pull request as ready for review March 12, 2025 17:20
@mcalinghee mcalinghee force-pushed the feat/allow_override_user branch 3 times, most recently from 8f7d65b to 0307f3c Compare March 17, 2025 10:32
@mcalinghee mcalinghee force-pushed the feat/allow_override_user branch from 0307f3c to 63f811a Compare March 25, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcalinghee