Insert client_name when upserting statically registered clients #4417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaultdino
changed the title
sandhose
approved these changes
Apr 30, 2025
Easy to add, I can make a lil PR for that some day soon |
sandhose
added
the
T-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using statically registered clients, the MAS consent screen fails to display a readable client_name when prompting the user for permission. It defaults to
client_idinstead ofclient_name, since theclient_namefield is not being populated during upsert (config sync).I propose these changes so that statically registered clients are slightly more streamlined to dynamically registered ones, allowing the user to see an actual informative name instead of the ULID
client_idfor the client.This would close my issue here