Skip to content

refactor(radio-speaker): replace useMemo with memo for preventing component re-rendering #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alamenai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(radio-speaker): replace useMemo with memo for preventing component re-rendering #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions apps/www/app/(app)/radio/components/radio-speaker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ const SpeakerContextBridge = ({ className }: { className?: string }) => {

playerRefStatic.current = player

return useMemo(
() => <SpeakerControls className={className} playerRef={playerRefStatic} />,
[className]
)
return <SpeakerControls className={className} playerRef={playerRefStatic} />
}

export function RadioSpeaker({ className }: { className?: string }) {
Expand Down Expand Up @@ -272,7 +269,7 @@ const VolumeSlider = memo(

VolumeSlider.displayName = "VolumeSlider"

function SpeakerControls({
const SpeakerControls = memo(function SpeakerControls({
className,
playerRef,
}: {
Expand Down Expand Up @@ -593,4 +590,6 @@ function SpeakerControls({
</div>
</Card>
)
}
})

SpeakerControls.displayName = "SpeakerControls"