Add right-click context menu for terminal panes#116
Open
PiratesIRC wants to merge 11 commits intoelirantutia:mainfrom
Open
Add right-click context menu for terminal panes#116PiratesIRC wants to merge 11 commits intoelirantutia:mainfrom
PiratesIRC wants to merge 11 commits intoelirantutia:mainfrom
Conversation
9 tasks
Owner
|
Hey @PiratesIRC — could you rebase this onto current main and resolve the conflicts before I review? Note that #115 already shipped (commented over there), so the dependency chain doesn't apply — this should rebase straight onto main as a standalone PR. Thanks! |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sary comments Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nnerHTML Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
a460a3c to
41c3dd2
Compare
Contributor
Author
|
@elirantutia rebased onto current main and dropped the close-confirm commits — this is now standalone with 10 context-menu-only commits. Resolved conflicts in |
…ed listeners Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tab-context-menuCSS classes for consistent styling and adds a small shortcut-hint style.src/renderer/components/terminal-context-menu.tsexposesshowTerminalContextMenu()/hideTerminalContextMenu(); integrated via acontextmenulistener onxtermWrapinterminal-pane.ts.pasteWithBracketedModehelper out ofterminal-pane.tsintoterminal-utils.tsso it can be reused by both the keyboard-paste path and the context menu Paste action.Test plan
npm run build)npm test)Dependencies
Stacked on #115 (close-confirmation). The diff currently shows 23 commits because the branch is layered on top of #115's 15 commits — the actual feature is the last 8 commits (
c99ef95…a460a3c). Once #115 merges, I'll rebase this branch onto freshmainand force-push so the diff drops to a clean 8-commit / context-menu-only view. Reviewing only the terminal-context-menu commits is also a reasonable workflow.🤖 Generated with Claude Code