CI with both old and new elixir

.github/workflows/ci.yml

@@ -1,23 +1,61 @@
 name: "CI"
-on: ["push", "pull_request"]
+on:
+ - push
+ - pull_request
 
 jobs:
   test_and_build:
-    name: "Build mix release"
-    runs-on: "ubuntu-latest"
+    runs-on: "ubuntu-20.04"
+    name: >-
+      Test on
+      Elixir ${{ matrix.elixir }} and Erlang/OTP ${{ matrix.otp }}
+      ${{ matrix.update-deps && 'with the latest dependencies' }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          # Test on all supported releases.
+          - { elixir: '1.11', otp: '24' }
+          - { elixir: '1.12', otp: '24' }
+          - { elixir: '1.13', otp: '24' }
+          - { elixir: '1.13', otp: '25' }
+          - { elixir: '1.14', otp: '24' }
+          - { elixir: '1.14', otp: '25' }
+          - { elixir: '1.14', otp: '25', update-deps: true }
     steps:
-    - run: |
-        wget https://packages.erlang-solutions.com/erlang-solutions_2.0_all.deb && sudo dpkg -i erlang-solutions_2.0_all.deb
-        sudo apt-get update
-        sudo apt-get install --allow-downgrades esl-erlang=1:24.3.3-1 inotify-tools
-        mkdir $HOME/elixir && cd $HOME/elixir
-        wget https://github.com/elixir-lang/elixir/releases/download/v1.11.4/Precompiled.zip
-        unzip Precompiled.zip
-        echo "$HOME/elixir/bin" >> $GITHUB_PATH
-    - uses: actions/checkout@v1
-    - run: |
-        mix local.hex --force
-        mix local.rebar --force
-        mix deps.get
-        mix lint
-        # mix test
+    - uses: actions/checkout@v3
+
+    - name: Setup dependency cache
+      uses: actions/cache@v3
+      with:
+        path: |
+          deps
+        key: mix-${{ hashFiles('mix.lock') }}
+
+    - name: Setup binary cache
+      uses: actions/cache@v3
+      with:
+        path: |
+          _build
+          priv/plts
+        key: ${{ matrix.elixir }}-${{ matrix.otp }}
+
+    - name: Setup beam
+      uses: erlef/setup-beam@v1
+      with:
+        elixir-version: ${{ matrix.elixir }}
+        otp-version: ${{ matrix.otp }}
+
+    - name: Unlock dependencies to get latest
+      if: ${{ matrix.update-deps }}
+      run: mix deps.unlock --all
+
+    - name: Fetch dependencies
+      run: mix deps.get
+
+    - name: Run linters
+      run: mix lint
+
+    # TODO: Tests should pass on the main branch.
+    # - name: Run tests
+    #  run: mix test

lib/desktop/menu.ex

@@ -343,18 +343,16 @@ defmodule Desktop.Menu do
 
   @impl true
   def handle_cast({:set_icon, icon}, menu) do
-    with {:ok, menu} <- set_adapter_icon(menu, icon) do
-      {:noreply, menu}
-    else
+    case set_adapter_icon(menu, icon) do
+      {:ok, menu} -> {:noreply, menu}
       _error -> {:noreply, menu}
     end
   end
 
   def handle_cast({:trigger_event, event}, menu = %{module: module}) do
     menu =
-      with {:ok, {:noreply, menu}} <- invoke_module_func(module, :handle_event, [event, menu]) do
-        update_dom(menu)
-      else
+      case invoke_module_func(module, :handle_event, [event, menu]) do
+        {:ok, {:noreply, menu}} -> update_dom(menu)
         _ -> menu
       end
 
@@ -419,9 +417,8 @@ defmodule Desktop.Menu do
   end
 
   defp proxy_handle_info(msg, menu = %Menu{module: module}) do
-    with {:ok, {:noreply, menu}} <- invoke_module_func(module, :handle_info, [msg, menu]) do
-      update_dom(menu)
-    else
+    case invoke_module_func(module, :handle_info, [msg, menu]) do
+      {:ok, {:noreply, menu}} -> update_dom(menu)
       _ -> menu
     end
   end

lib/desktop/menu/adapters/wx.ex

@@ -154,21 +154,21 @@ defmodule Desktop.Menu.Adapter.Wx do
   end
 
   defp create_taskbar_icon(fn_create_popup, icon) do
-    with {:ok, taskbar_icon = %TaskBarIcon{wx_taskbar_icon: wx_taskbar_icon}} <-
-           TaskBarIcon.create(fn_create_popup) do
-      TaskBarIcon.connect(taskbar_icon)
-      TaskBarIcon.set_icon(taskbar_icon, icon)
-
-      if OS.type() == Windows do
-        # This links the taskbar icon and the application itself on Windows
-        if Code.ensure_loaded?(:wxNotificationMessage) &&
-             Kernel.function_exported?(:wxNotificationMessage, :useTaskBarIcon, 1) do
-          :wxNotificationMessage.useTaskBarIcon(wx_taskbar_icon)
+    case TaskBarIcon.create(fn_create_popup) do
+      {:ok, taskbar_icon = %TaskBarIcon{wx_taskbar_icon: wx_taskbar_icon}} ->
+        TaskBarIcon.connect(taskbar_icon)
+        TaskBarIcon.set_icon(taskbar_icon, icon)
+
+        if OS.type() == Windows do
+          # This links the taskbar icon and the application itself on Windows
+          if Code.ensure_loaded?(:wxNotificationMessage) &&
+               Kernel.function_exported?(:wxNotificationMessage, :useTaskBarIcon, 1) do
+            :wxNotificationMessage.useTaskBarIcon(wx_taskbar_icon)
+          end
         end
-      end
 
-      taskbar_icon
-    else
+        taskbar_icon
+
       error ->
         Logger.warning("Failed to create TaskBar Icon: #{inspect(error)}")
         nil

lib/desktop/window.ex

@@ -494,9 +494,7 @@ defmodule Desktop.Window do
     case Enum.find(noties, fn {_, {wx_ref, _callback}} -> wx_ref == obj end) do
       nil ->
         Logger.error(
-          "Received unhandled notification event #{inspect(obj)}: #{inspect(action)} (#{
-            inspect(noties)
-          })"
+          "Received unhandled notification event #{inspect(obj)}: #{inspect(action)} (#{inspect(noties)})"
         )
 
       {_, {_ref, nil}} ->

mix.exs

@@ -13,7 +13,8 @@ defmodule Desktop.MixProject do
       description: """
       Write Desktop Apps with Elixir.
       """,
-      elixir: "~> 1.10",
+      elixir: "~> 1.11",
+      # TODO: Also requires otp: "~> 24"
       elixirc_paths: elixirc_paths(Mix.env()),
       compilers: Mix.compilers(),
       aliases: aliases(),