Skip to content

Fix deprecation warning in 1.17/1.18 + update deps#134

Open
tmjoen wants to merge 3 commits into
elixirs:mainfrom
tmjoen:main
Open

Fix deprecation warning in 1.17/1.18 + update deps#134
tmjoen wants to merge 3 commits into
elixirs:mainfrom
tmjoen:main

Conversation

@tmjoen

@tmjoen tmjoen commented Dec 21, 2024

Copy link
Copy Markdown

Fixed this warning:

==> base62
Compiling 1 file (.ex)
    warning: single-quoted strings represent charlists. Use ~c"" if you indeed want a charlist or use "" instead.
    You may run "mix format --migrate" to fix this warning automatically.
    │
  2 │   use CustomBase, '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz'
    │                   ~
    │
    └─ lib/base62.ex:2:19

Also updated test/dev deps to latest version. Bumped required Elixir version to 1.12 (which is still ancient :)) to support newer stream_data dep.

@tmjoen

tmjoen commented Dec 21, 2024

Copy link
Copy Markdown
Author

We should probably update the Github actions as well since I'd assume this PR will fail on 1.11.x

@mloftis

mloftis commented Apr 2, 2025

Copy link
Copy Markdown

Just chiming in a +1 on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants