Made ast_optional non-destructive - #1455
Open
vojtref wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made
ast_optionalretrieve attributes from the attribute map non-destructively.Additional Notes
Previous behaviour had the
:timeoutattribute (currently the only reused attribute) immediately discarded even when checking non-existent command handlers, with all subsequent uses defaulting to 200 ms (see linked issues below). Keeping optional attributes in the property map avoids this problem, and potential future issues with attribute reuse.ast_requiredmay, at present, be kept destructive, as no required attributes are reused. Making all retrieval non-destructive is, however, worth considering.Fixes #715.
Fixes #756.
Fixes #965.
Checklist
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing