-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secret and namespace completion (requires kubectl 1.26) #35
Open
maelvls
wants to merge
3
commits into
elsesiy:master
Choose a base branch
from
maelvls:kubectl-plugin-completion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,7 @@ func NewCmdViewSecret() *cobra.Command { | |
|
||
return nil | ||
}, | ||
ValidArgsFunction: getSecretsOrKeys, | ||
} | ||
|
||
cmd.Flags(). | ||
|
@@ -92,6 +93,7 @@ func NewCmdViewSecret() *cobra.Command { | |
cmd.Flags().StringVarP(&res.customContext, "context", "c", res.customContext, "override the current context") | ||
cmd.Flags().StringVarP(&res.kubeConfig, "kubeconfig", "k", res.kubeConfig, "explicitly provide the kubeconfig to use") | ||
|
||
cmd.Root().RegisterFlagCompletionFunc("namespace", getNamespaces) | ||
return cmd | ||
} | ||
|
||
|
@@ -191,3 +193,167 @@ func ProcessSecret(outWriter, errWriter io.Writer, secret map[string]interface{} | |
|
||
return nil | ||
} | ||
|
||
func getNamespaces(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | ||
if len(args) > 0 { | ||
return nil, cobra.ShellCompDirectiveNoFileComp | ||
} | ||
|
||
ctxOverride, _ := cmd.Flags().GetString("context") | ||
kubeConfigOverride, _ := cmd.Flags().GetString("kubeconfig") | ||
|
||
var res, cmdErr bytes.Buffer | ||
commandArgs := []string{"get", "namespaces", "-o", "json"} | ||
|
||
if ctxOverride != "" { | ||
commandArgs = append(commandArgs, "--context", ctxOverride) | ||
} | ||
|
||
if kubeConfigOverride != "" { | ||
commandArgs = append(commandArgs, "--kubeconfig", kubeConfigOverride) | ||
} | ||
|
||
out := exec.Command("kubectl", commandArgs...) | ||
out.Stdout = &res | ||
out.Stderr = &cmdErr | ||
err := out.Run() | ||
if err != nil { | ||
return nil, cobra.ShellCompDirectiveError | ||
} | ||
|
||
var parsed struct { | ||
Items []struct { | ||
Metadata struct { | ||
Name string `json:"name"` | ||
} `json:"metadata,omitempty"` | ||
} | ||
} | ||
if err := json.Unmarshal(res.Bytes(), &parsed); err != nil { | ||
return nil, cobra.ShellCompDirectiveError | ||
} | ||
|
||
// turn into a list of strings | ||
var namespaces []string | ||
for _, item := range parsed.Items { | ||
namespaces = append(namespaces, item.Metadata.Name) | ||
} | ||
|
||
return namespaces, cobra.ShellCompDirectiveNoFileComp | ||
} | ||
|
||
func getSecretsOrKeys(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | ||
// The first argument is the secret name. | ||
if len(args) == 0 { | ||
return getSecrets(cmd, args, toComplete) | ||
} | ||
|
||
// The second argument is the key. | ||
if len(args) == 1 { | ||
return getSecretKeys(cmd, args, toComplete) | ||
} | ||
|
||
return nil, cobra.ShellCompDirectiveNoFileComp | ||
} | ||
|
||
func getSecrets(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
nsOverride, _ := cmd.Flags().GetString("namespace") | ||
ctxOverride, _ := cmd.Flags().GetString("context") | ||
kubeConfigOverride, _ := cmd.Flags().GetString("kubeconfig") | ||
|
||
var res, cmdErr bytes.Buffer | ||
commandArgs := []string{"get", "secrets", "-o", "json"} | ||
if nsOverride != "" { | ||
commandArgs = append(commandArgs, "-n", nsOverride) | ||
} | ||
|
||
if ctxOverride != "" { | ||
commandArgs = append(commandArgs, "--context", ctxOverride) | ||
} | ||
|
||
if kubeConfigOverride != "" { | ||
commandArgs = append(commandArgs, "--kubeconfig", kubeConfigOverride) | ||
} | ||
|
||
out := exec.Command("kubectl", commandArgs...) | ||
out.Stdout = &res | ||
out.Stderr = &cmdErr | ||
err := out.Run() | ||
if err != nil { | ||
return nil, cobra.ShellCompDirectiveError | ||
} | ||
|
||
var parsed struct { | ||
Items []struct { | ||
Metadata struct { | ||
Name string `json:"name"` | ||
} `json:"metadata,omitempty"` | ||
} | ||
} | ||
if err := json.Unmarshal(res.Bytes(), &parsed); err != nil { | ||
return nil, cobra.ShellCompDirectiveError | ||
} | ||
|
||
// turn into a list of strings | ||
var names []string | ||
for _, item := range parsed.Items { | ||
names = append(names, item.Metadata.Name) | ||
} | ||
|
||
return names, cobra.ShellCompDirectiveNoFileComp | ||
} | ||
|
||
func getSecretKeys(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | ||
// We are now completing the second argument, the key: | ||
// | ||
// kubectl view-secret example-secret <TAB><TAB> | ||
// <------------> <--------> | ||
// args[0] toComplete | ||
// | ||
|
||
if len(args) != 1 { | ||
return nil, cobra.ShellCompDirectiveNoFileComp | ||
} | ||
secretName := args[0] | ||
|
||
nsOverride, _ := cmd.Flags().GetString("namespace") | ||
ctxOverride, _ := cmd.Flags().GetString("context") | ||
kubeConfigOverride, _ := cmd.Flags().GetString("kubeconfig") | ||
|
||
var res, cmdErr bytes.Buffer | ||
commandArgs := []string{"get", "secrets", secretName, "-o", "json"} | ||
if nsOverride != "" { | ||
commandArgs = append(commandArgs, "-n", nsOverride) | ||
} | ||
|
||
if ctxOverride != "" { | ||
commandArgs = append(commandArgs, "--context", ctxOverride) | ||
} | ||
|
||
if kubeConfigOverride != "" { | ||
commandArgs = append(commandArgs, "--kubeconfig", kubeConfigOverride) | ||
} | ||
|
||
out := exec.Command("kubectl", commandArgs...) | ||
out.Stdout = &res | ||
out.Stderr = &cmdErr | ||
err := out.Run() | ||
if err != nil { | ||
return nil, cobra.ShellCompDirectiveError | ||
} | ||
|
||
var parsed struct { | ||
Data map[string]string `json:"data,omitempty"` | ||
} | ||
|
||
if err := json.Unmarshal(res.Bytes(), &parsed); err != nil { | ||
return nil, cobra.ShellCompDirectiveError | ||
} | ||
|
||
var keys []string | ||
for k := range parsed.Data { | ||
keys = append(keys, k) | ||
} | ||
sort.Strings(keys) | ||
|
||
return keys, cobra.ShellCompDirectiveNoFileComp | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like
toComplete
is unused