Skip to content

Add metadata to feature list for build checks#103

Merged
diondokter merged 4 commits into
embassy-rs:mainfrom
9names:ci_check_metadata
May 6, 2026
Merged

Add metadata to feature list for build checks#103
diondokter merged 4 commits into
embassy-rs:mainfrom
9names:ci_check_metadata

Conversation

@9names

@9names 9names commented May 5, 2026

Copy link
Copy Markdown
Contributor

Since I managed to break it in a change, best that CI catches it next time.

@9names 9names marked this pull request as draft May 5, 2026 11:03
@9names 9names force-pushed the ci_check_metadata branch from 9ae5869 to 8396b95 Compare May 5, 2026 11:22
@9names

9names commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

Looks like I was wrong about metapacs not having their metadata overwritten.
2nd try to fix generate.rs (this time with tests to confirm that it actually works).
Would you like me to remove the regeneration commits?

@9names 9names marked this pull request as ready for review May 5, 2026 12:49
@diondokter diondokter merged commit 8f0d793 into embassy-rs:main May 6, 2026
21 checks passed
@diondokter

Copy link
Copy Markdown
Contributor

That's good to have. The metadata thing is a bit unfortunate, but oh well

@9names 9names deleted the ci_check_metadata branch May 6, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants